-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include markers issue #5092 #5114
Conversation
@ImreC thanks for contributing again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my other comment about test and news.
Yeah sure. Was just checking if this was literally it. Will do that later today |
Yeah that seems like the logical change. @ImreC Not sure you timeline, but I'd like to do another pipenv release due to another issue in the next week or so and would love if we could include this one as well. |
Hi @matteius, this completely fell off the map on my end. I'm having a very busy couple of weeks. I will find some time on Friday to do this |
@ImreC I am thinking it should be the default behavior to include markers, but perhaps a flag like you have to exclude them (non-default) makes sense? Especially with reports like this, having the ability to exclude markers may be relevant for some: Also, Not sure if you saw my comment the other day I CC'd you on another issue report, the TLDR is (having trouble finding the ticket link)
|
I tend to agree here, the flag should actually be |
@@ -281,6 +281,7 @@ flag:: | |||
pytest==3.2.3 | |||
|
|||
Adding the ``--hash`` flag will add package hashes to the output for extra security. | |||
Adding the ``--exclude-markers`` flagwill exclude the markers from the output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo need space flag will
-- I tried to edit this but I don't think I can directly without some hoop jumping.
if dev or dev_only: | ||
deps.update(lockfile["develop"]) | ||
if not dev_only: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for flipping the ordering here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve @ImreC nice work -- just if you can please add the space for the typo so we can merge soon.
@oz123 I am not seeing what you mean by a potential merge conflict ... If there is not one, I am ready to merge this and will push a commit to main to fix the documentation typo. |
@matteius @oz123 I think this is literally what needs to happen for this, after the changes that were done a month ago. Or am I overlooking something?